Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 2018 edition idioms #237

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Update to 2018 edition idioms #237

merged 5 commits into from
Oct 16, 2019

Conversation

Demi-Marie
Copy link
Contributor

As requested by @niklasad1.

@parity-cla-bot
Copy link

It looks like @demimarie-parity hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@Demi-Marie Demi-Marie mentioned this pull request Oct 9, 2019
Closed
gui1117
gui1117 reviewed Oct 9, 2019
View reviewed changes
uint/tests/uint_tests.rs Outdated Show resolved Hide resolved
uint/tests/uint_tests.rs Outdated Show resolved Hide resolved
ethbloom/src/lib.rs Show resolved Hide resolved
debris
debris reviewed Oct 15, 2019
View reviewed changes
Copy link
Contributor

@debris debris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few minor grumbles

parity-crypto/benches/bench.rs Show resolved Hide resolved
uint/benches/bigint.rs Outdated Show resolved Hide resolved
uint/benches/bigint.rs Outdated Show resolved Hide resolved
uint/tests/uint_tests.rs Outdated Show resolved Hide resolved
niklasad1
niklasad1 approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@debris debris merged commit e9e3ab3 into master Oct 16, 2019
@debris debris deleted the demi-2018-edition-idioms branch October 16, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gui1117 gui1117 gui1117 left review comments

@niklasad1 niklasad1 niklasad1 approved these changes

@debris debris debris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Demi-Marie @parity-cla-bot @debris @gui1117 @niklasad1