Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing width for Sender Component. #286

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Fixing width for Sender Component. #286

merged 2 commits into from
Sep 17, 2021

Conversation

hbulgarini
Copy link
Contributor

Related to #276 #270

This PR solves some design issues related with sender component size when account names are larger:

  1. Balance has a margin left now.
  2. The account name has an ellipsis that wraps the text and does not increase the size.
  3. When the focus is on the address item, there is a tooltip that shows native/companion addresses:

screenshots below:

Screen Shot 2021-09-17 at 10 53 37

Screen Shot 2021-09-17 at 10 53 48

Screen Shot 2021-09-17 at 10 53 59

@hbulgarini hbulgarini requested a review from tomusdrw September 17, 2021 13:55
@hbulgarini
Copy link
Contributor Author

@tomusdrw , i set yourself as reviewer in case you want to review the design.

@hbulgarini hbulgarini merged commit 067d8bc into master Sep 17, 2021
@hbulgarini hbulgarini deleted the hb-fix-width-issue-sender branch September 17, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbulgarini @tomusdrw