Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local image and don't crash when logo is missing. #284

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

tomusdrw
Copy link
Contributor

I'm trying to finish up paritytech/parity-bridges-common#1047 and currently the docker-compose networks are running with "Local Network" chain name.
Currently this crashes the UI, cause the module with logo cannot be loaded.

This PR adds an icon for local.png and also uses that icon as a fallback. (currently just copy-pasted Rialto's icon).

@tomusdrw tomusdrw requested a review from hbulgarini September 13, 2021 13:21
Copy link
Contributor

@hbulgarini hbulgarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch.

@hbulgarini
Copy link
Contributor

CC @tomusdrw : merging it.

@hbulgarini hbulgarini merged commit 3934c6d into master Sep 14, 2021
@hbulgarini hbulgarini deleted the td-image branch September 14, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants