Override provider URLs in Docker container runtime #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbulgarini
approved these changes
Sep 10, 2021
|
@tomusdrw feel free to merge when you consider the PR is ready. |
|
@hbulgarini thanks! Do you mind publishing the release whenever you feel it's the right time? This would allow paritytech/parity-bridges-common#1047 to move forward. |
Sure. I think this PR is enough to justify a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hacky workaround to make sure we don't rebuild the app while starting the docker image.
Basically we replace the default URL with the one provided using ENV variables.
Closes #201
Companion to: paritytech/parity-bridges-common#1047