Fix logic for letting the user execute the transaction based on available funds. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262 .
Closes #267.
As described in the GH issue 262, this PR is actually implementing the following two behaviors:
Another enhancement introduced on this PR is that the enough funds calculation is now happening on the reducer logic 100% and there is a hook in the data model that triggers the update in case balance gets updated.
Also this PR solves the bug described in the #267 and now the fee is correctly deducted from the balance sender ( shows the same fee as polkadotjs )