-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass finality proof verification context to the call builder #2823
Merged
svyatonik
merged 2 commits into
polkadot-staging
from
sv-pass-justification-verification-context-to-call-builder
Feb 6, 2024
Merged
Pass finality proof verification context to the call builder #2823
svyatonik
merged 2 commits into
polkadot-staging
from
sv-pass-justification-verification-context-to-call-builder
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
the
A-chores
Something that has to be done, as part of regular maintenance
label
Feb 6, 2024
10 tasks
serban300
reviewed
Feb 6, 2024
serban300
approved these changes
Feb 6, 2024
svyatonik
deleted the
sv-pass-justification-verification-context-to-call-builder
branch
February 6, 2024 08:36
svyatonik
added a commit
that referenced
this pull request
Feb 7, 2024
* pass verification context to the build_submit_finality_proof_call * current_set_id -> context
svyatonik
added a commit
that referenced
this pull request
Feb 7, 2024
* Add submit_finality_proof_ex call to the GRANDPA pallet (#2821) * depreacte submit_finality_proof and introduce submit_finality_proof_ex instead * propagate changes to the rest of runtime crates * tests for new call * suppress deprecation warning * revert changes to benchmarks to avoid unnecessary compilation issues when integrating to other repos * Pass finality proof verification context to the call builder (#2823) * pass verification context to the build_submit_finality_proof_call * current_set_id -> context
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
…ech#2823) * pass verification context to the build_submit_finality_proof_call * current_set_id -> context
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
…ech#2823) * pass verification context to the build_submit_finality_proof_call * current_set_id -> context
bkontur
pushed a commit
that referenced
this pull request
May 7, 2024
* Add submit_finality_proof_ex call to the GRANDPA pallet (#2821) * depreacte submit_finality_proof and introduce submit_finality_proof_ex instead * propagate changes to the rest of runtime crates * tests for new call * suppress deprecation warning * revert changes to benchmarks to avoid unnecessary compilation issues when integrating to other repos * Pass finality proof verification context to the call builder (#2823) * pass verification context to the build_submit_finality_proof_call * current_set_id -> context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2822
No logic changes here - it just prepares everything to build new
submit_finality_proof_ex
call