Backport from polkadot-sdk with actual master
#2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
commented
Oct 18, 2023
bin/rialto/node/Cargo.toml
Outdated
| @@ -47,7 +47,7 @@ polkadot-node-core-pvf-execute-worker = { git = "https://github.com/paritytech/p | |||
| polkadot-node-core-pvf-prepare-worker = { git = "https://github.com/paritytech/polkadot-sdk", branch = "master" } | |||
| polkadot-primitives = { git = "https://github.com/paritytech/polkadot-sdk", branch = "master" } | |||
| polkadot-runtime-parachains = { git = "https://github.com/paritytech/polkadot-sdk", branch = "master" } | |||
| polkadot-service = { git = "https://github.com/paritytech/polkadot-sdk", branch = "master", default-features = false, features = [ "full-node", "polkadot-native" ] } | |||
| polkadot-service = { git = "https://github.com/paritytech/polkadot-sdk", branch = "master", default-features = false, features = [ "full-node", "westend-native" ] } | |||
There was a problem hiding this comment.
@svyatonik polkadot-runtime is removed from polkadot-sdk, changed it to westend-runtime and lets see if it works. Do we need to change anything else polkadot->westend related for rialto?
There was a problem hiding this comment.
I don't think we need any runtime for that - the reason it is here (iirc) is because polkadot-service required at least one of *-runtime features to compile. If it does compile without it, we could remove this feature at all
There was a problem hiding this comment.
looks like without any runtime it causes this error: https://gitlab.parity.io/parity/mirrors/parity-bridges-common/-/jobs/4006286,
I will leave westend-runtime
There was a problem hiding this comment.
ok, missing runtime feaure is not a problem, we need to fix probably feature flags propagation:
~/parity/parity-bridges-common$ zepter lint propagate-feature --feature runtime-benchmarks --left-side-feature-missing=ignore --workspace --feature-enables-dep="runtime-benchmarks:frame-benchmarking" --locked
crate 'millau-runtime'
feature 'runtime-benchmarks'
must propagate to:
pallet-bridge-grandpa
crate 'rialto-parachain-runtime'
feature 'runtime-benchmarks'
must propagate to:
bridge-runtime-common
pallet-bridge-grandpa
pallet-bridge-messages
pallet-bridge-relayers
crate 'rialto-runtime'
feature 'runtime-benchmarks'
must propagate to:
pallet-bridge-grandpa
pallet-bridge-relayers
Found 7 issues (run with --fix to fix).
continue tomorrow, if this will work, maybe zepter will work in our CI also
acatangiu
approved these changes
Oct 18, 2023
svyatonik
approved these changes
Oct 18, 2023
bkontur
added a commit
that referenced
this pull request
Oct 19, 2023
* Backport from `polkadot-sdk` * lingua stuff * Fixes * Fix * Features? * Fix - v5 -> v6 * zepter format features * try zepter with CI * Fix imports * Fix * Fix * Fix * Revert zepther pipeline
bkontur
added a commit
that referenced
this pull request
Oct 19, 2023
* Backport from `polkadot-sdk` * lingua stuff * Fixes * Fix * Features? * Fix - v5 -> v6 * zepter format features * try zepter with CI * Fix imports * Fix * Fix * Fix * Revert zepther pipeline
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* Backport from `polkadot-sdk` * lingua stuff * Fixes * Fix * Features? * Fix - v5 -> v6 * zepter format features * try zepter with CI * Fix imports * Fix * Fix * Fix * Revert zepther pipeline
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* Backport from `polkadot-sdk` * lingua stuff * Fixes * Fix * Features? * Fix - v5 -> v6 * zepter format features * try zepter with CI * Fix imports * Fix * Fix * Fix * Revert zepther pipeline
bkontur
added a commit
that referenced
this pull request
May 7, 2024
* Backport from `polkadot-sdk` * lingua stuff * Fixes * Fix * Features? * Fix - v5 -> v6 * zepter format features * try zepter with CI * Fix imports * Fix * Fix * Fix * Revert zepther pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.