Fix using unimported priority structs #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
approved these changes
Jun 11, 2024
AndreiEres
changed the title
sandreim
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80
v0.3.7 requires importing of priority related structs what conflicts with the definition of a patch version
In this PR priority related structs prefixed with
#support_crate ::that points to otchestra so it doesn't require the explicit import to use#[subsystem].However if the
Sendertrait is used it still requires to implement new methodssend_message_with_priorityandtry_send_message_with_priority. This PR paritytech/polkadot-sdk#4763 shows required changes.So I suggest bumping the library to v0.4.0. v0.3.7 should be yanked.