Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: Fix cargo clippy #57

Closed
wants to merge 9 commits into from
Closed

clippy: Fix cargo clippy #57

wants to merge 9 commits into from

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Mar 13, 2024

This PR fixes:

  • clippy lints
  • rust doc missing links
  • remove unused dependency

lexnv added 9 commits March 13, 2024 20:06
@lexnv
Fix clippy
ae8957a 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
Clippy more fixes
eae5737 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
cargo: Remove unused dependency
c9d27fa 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
yamux: Fix docs
bc16993 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
clippy: Allow large Result::Err()
c7b45bc 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
clippy: Use &[slice] instead of &Vec<_>
e618b7b 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
clippy: Fix for_kv_map
032e65e 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
clippy: More fixes
0f04c48 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
clippy: More fixes
d9af495 
Signed-off-by: Alexandru Vasile <[email protected]>
dmitry-markin
dmitry-markin approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@dmitry-markin dmitry-markin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good, but did you run the tests just to make sure everything is OK? Don't know, may be even check with a real node, because the changes are quite bulky.

This was referenced Mar 18, 2024
Merged
Merged
@lexnv lexnv mentioned this pull request Apr 22, 2024
Merged
1 task
@lexnv lexnv closed this Apr 22, 2024
lexnv added a commit that referenced this pull request Apr 24, 2024
@lexnv
Fix clippy (#83)
19515ea 
Builds on #57, however due to
the high number of conflicts I fixed the errors in this PR.


### Next Steps

- [ ] Sync node with this PR

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-markin dmitry-markin dmitry-markin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lexnv @dmitry-markin