Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify: Sufix litep2p to the agent version for visibility #316

Closed
wants to merge 2 commits into from

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Jan 10, 2025

This PR adds the (litep2p) suffix to the agent version (user agent) of the identify protocol.

The change is needed to gain visibility into network backends and determine exactly the number of validators that are running litep2p.
Using tools like subp2p-explorer, we can determine if the litep2p validators were responsible for finality lags in kusama.

This reflects on the identify protocol:

info=Identify {
  protocol_version: Some("/substrate/1.0"),
  agent_version: Some("polkadot-parachain/v1.17.0-967989c5d94 (kusama-node-name-01) (litep2p)")
  ...
}

cc @paritytech/networking

@lexnv lexnv self-assigned this Jan 10, 2025
Comment on lines +203 to +206
user_agent: config
.user_agent
.map(|agent| format!("{} {}", agent, AGENT_SUFIX))
.unwrap_or(DEFAULT_AGENT.to_string()),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should go to substrate, not litep2p, to let developers using litep2p set the user agent they want.

@lexnv
Copy link
Collaborator Author

lexnv commented Jan 13, 2025

Closing this, will move to substrate, thanks for the review 🙏

@lexnv lexnv closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants