identify: Replace FuturesUnordered with FuturesStream #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
added
enhancement
iulianbarbu
reviewed
Dec 11, 2024
| @@ -356,7 +357,10 @@ impl Identify { | |||
| loop { | |||
| tokio::select! { | |||
| event = self.service.next() => match event { | |||
| None => return, | |||
| None => { | |||
| tracing::warn!(target: LOG_TARGET, "transport service stream ended, terminating identify event loop"); | |||
There was a problem hiding this comment.
Is this a warn because a terminated identify loop is not expected in normal operation?
There was a problem hiding this comment.
Yep, we don't expect any of these components to exit under normal circumstances. If they exit however, this should give us enough information about what happened to isolate the issue 🙏
dmitry-markin
approved these changes
Dec 11, 2024
Co-authored-by: Dmitry Markin <[email protected]>
lexnv
added a commit
that referenced
this pull request
Dec 12, 2024
## [0.8.4] - 2024-12-12 This release aims to make the MDNS component more robust by fixing a bug that caused the MDNS service to fail to register opened substreams. Additionally, the release includes several improvements to the `identify` protocol, replacing `FuturesUnordered` with `FuturesStream` for better performance. ### Fixed - mdns/fix: Failed to register opened substream ([#301](#301)) ### Changed - identify: Replace FuturesUnordered with FuturesStream ([#302](#302)) - chore: Update hickory-resolver to version 0.24.2 ([#304](#304)) - ci: Ensure cargo-machete is working with rust version from CI ([#303](#303)) cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]>
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Dec 12, 2024
## [0.8.4] - 2024-12-12 This release aims to make the MDNS component more robust by fixing a bug that caused the MDNS service to fail to register opened substreams. Additionally, the release includes several improvements to the `identify` protocol, replacing `FuturesUnordered` with `FuturesStream` for better performance. ### Fixed - mdns/fix: Failed to register opened substream ([#301](paritytech/litep2p#301)) ### Changed - identify: Replace FuturesUnordered with FuturesStream ([#302](paritytech/litep2p#302)) - chore: Update hickory-resolver to version 0.24.2 ([#304](paritytech/litep2p#304)) - ci: Ensure cargo-machete is working with rust version from CI ([#303](paritytech/litep2p#303)) cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
added a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Dec 12, 2024
## [0.8.4] - 2024-12-12 This release aims to make the MDNS component more robust by fixing a bug that caused the MDNS service to fail to register opened substreams. Additionally, the release includes several improvements to the `identify` protocol, replacing `FuturesUnordered` with `FuturesStream` for better performance. ### Fixed - mdns/fix: Failed to register opened substream ([#301](paritytech/litep2p#301)) ### Changed - identify: Replace FuturesUnordered with FuturesStream ([#302](paritytech/litep2p#302)) - chore: Update hickory-resolver to version 0.24.2 ([#304](paritytech/litep2p#304)) - ci: Ensure cargo-machete is working with rust version from CI ([#303](paritytech/litep2p#303)) cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]>
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
## [0.8.4] - 2024-12-12 This release aims to make the MDNS component more robust by fixing a bug that caused the MDNS service to fail to register opened substreams. Additionally, the release includes several improvements to the `identify` protocol, replacing `FuturesUnordered` with `FuturesStream` for better performance. ### Fixed - mdns/fix: Failed to register opened substream ([paritytech#301](paritytech/litep2p#301)) ### Changed - identify: Replace FuturesUnordered with FuturesStream ([paritytech#302](paritytech/litep2p#302)) - chore: Update hickory-resolver to version 0.24.2 ([paritytech#304](paritytech/litep2p#304)) - ci: Ensure cargo-machete is working with rust version from CI ([paritytech#303](paritytech/litep2p#303)) cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the identify
FuturesUnorderedwithFuturesStream. This effectively fixes delays in processing outbound events.Related to:
poll_next#287cc @paritytech/networking