Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ed25519-dalek to v2.1.1 #122

Merged
merged 3 commits into from
Jun 20, 2024
Merged

chore: update ed25519-dalek to v2.1.1 #122

merged 3 commits into from
Jun 20, 2024

Conversation

koushiro
Copy link
Contributor

Close #94

Copy link
Collaborator

@dmitry-markin dmitry-markin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for contributing! This will require minor updates in polkadot-sdk due to public API changes, but I can handle it after releasing these changes in litep2p.

@dmitry-markin
Copy link
Collaborator

@koushiro As the CI error says, would it be possible for you to sign the commit with your GutHub GPG key?

Copy link
Collaborator

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing! 🙏

@dmitry-markin dmitry-markin merged commit ceb583c into paritytech:master Jun 20, 2024
8 checks passed
@dmitry-markin
Copy link
Collaborator

Thanks again for contributing, and sorry that merging this took quite some time. We are going to reconsider requiring signed commits from external contributors.

@koushiro koushiro deleted the update-ed25519-dalek branch June 20, 2024 11:30
dmitry-markin added a commit that referenced this pull request Jun 20, 2024
## [0.6.1] - 2024-06-20

This is a bug fixing and security release. curve255190-dalek has been upgraded to v4.1.3, see
[dalek-cryptography/curve25519-dalek#659](dalek-cryptography/curve25519-dalek#659)
for details.

### Fixed

- kad: Set default ttl 36h for kad records
([#154](#154))
- chore: update ed25519-dalek to v2.1.1
([#122](#122))
- Bump curve255190-dalek 4.1.2 -> 4.1.3
([#159](#159))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants