fix(http server): omit jsonrpc details in health API #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing #784 Ordinary GET requests doesn't expect the body the be formatted as `JSON-RPC` responses which this fixes.
niklasad1
changed the title
niklasad1
commented
May 26, 2022
jsdw
reviewed
May 26, 2022
Comment on lines
+181
to
+183
| if !path.starts_with("/") { | ||
| return Err(Error::Custom(format!("Health endpoint path must start with `/` to work, got: {}", path))); | ||
| } |
There was a problem hiding this comment.
Just wondering; why do we care about the path starting with '/'?
There was a problem hiding this comment.
Because we have this check, if / is missing that will fail and it's quite tricky to debug.
I have already done that myself but more ideally would be Path type instead of a String
There was a problem hiding this comment.
Ah ok gotcha; that makes sense!
jsdw
approved these changes
May 26, 2022
niklasad1
commented
May 31, 2022
lexnv
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #784
Ordinary HTTP GET requests doesn't expect the body the be formatted as
JSON-RPCresponses which this fixes i.e, just regular JSON.