Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc module): close subscription task when a subscription is unsubscribed via the unsubscribe call #743

Merged
merged 16 commits into from
Apr 29, 2022
Merged

fix(rpc module): close subscription task when a subscription is unsubscribed via the unsubscribe call #743

merged 16 commits into from
Apr 29, 2022

Commits on Apr 28, 2022

  1. refactor: remove SubscriptionSink::inner_send

    @niklasad1
    niklasad1 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    8fca567 View commit details
    Browse the repository at this point in the history

  2. fix: close running task if unsubscribed

    @niklasad1
    niklasad1 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    2caadf1 View commit details
    Browse the repository at this point in the history

  3. Update core/src/server/rpc_module.rs

    @niklasad1
    niklasad1 authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    804e211 View commit details
    Browse the repository at this point in the history

  4. Update core/src/server/rpc_module.rs

    @niklasad1
    niklasad1 authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    ad73b9c View commit details
    Browse the repository at this point in the history

  5. fix nits

    @niklasad1
    niklasad1 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    d9cb04d View commit details
    Browse the repository at this point in the history

  6. Update core/src/server/rpc_module.rs

    @niklasad1
    niklasad1 authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    61f85d8 View commit details
    Browse the repository at this point in the history

  7. add test for canceling subscriptions

    @niklasad1
    niklasad1 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    3ed48df View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/na-close-tasks-when-unsubscribed… 

    …' into na-close-tasks-when-unsubscribed
    @niklasad1
    niklasad1 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    c715492 View commit details
    Browse the repository at this point in the history

  9. print subscription info; once per minute

    @niklasad1
    niklasad1 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    366176a View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. revert closure stuff

    @niklasad1
    niklasad1 committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    0d99095 View commit details
    Browse the repository at this point in the history

  2. Revert "print subscription info; once per minute" 

    This reverts commit 366176a.
    @niklasad1
    niklasad1 committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    eb5f7f2 View commit details
    Browse the repository at this point in the history

  3. use tokio::sync::watch instead of oneshot 

    The receiver is clonable and it's possible to check whether the sender is still alive
    @niklasad1
    niklasad1 committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    fab13ef View commit details
    Browse the repository at this point in the history

  4. Update tests/tests/helpers.rs 

    Co-authored-by: David <[email protected]>
    @niklasad1 @dvdplm
    niklasad1 and dvdplm authored Apr 29, 2022
    Configuration menu
    Copy the full SHA
    f1a945b View commit details
    Browse the repository at this point in the history

  5. Update core/src/server/rpc_module.rs 

    Co-authored-by: David <[email protected]>
    @niklasad1 @dvdplm
    niklasad1 and dvdplm authored Apr 29, 2022
    Configuration menu
    Copy the full SHA
    6a722d7 View commit details
    Browse the repository at this point in the history

  6. grumbles: use unwrap in tests

    @niklasad1
    niklasad1 committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    ce7de38 View commit details
    Browse the repository at this point in the history

  7. add test for reuse pipe_from_stream

    @niklasad1
    niklasad1 committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    23fb16f View commit details
    Browse the repository at this point in the history