feat: add SubscriptionSink::pipe_from_try_stream to support streams that returns Result
#720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rationale for this is that it is more flexible for use cases when `Stream<Item = Result<T, Error>>`. Take for example `tokio_stream::Broadcast` then one would have to something like: ```rust let stream = BroadcastStream::new(rx).take_while(|r| future::ready(r.is_ok())).filter_map(|r| future::ready(r.ok())); ``` Of course it's a bit awkward to return `Result` when the underlying stream can't fail but I think that's fair trade-off here.
TarikGul
reviewed
Mar 30, 2022
TarikGul
approved these changes
Mar 30, 2022
Co-authored-by: Tarik Gul <[email protected]>
…nto na-resultify-pipe-from-stream
jsdw
reviewed
Mar 31, 2022
jsdw
reviewed
Mar 31, 2022
jsdw
reviewed
Mar 31, 2022
jsdw
reviewed
Mar 31, 2022
| assert_eq!(sub.next().await.unwrap().unwrap(), 1); | ||
| let exp = SubscriptionClosed::new(SubscriptionClosedReason::Server(err.to_string())); | ||
| // The server closed down the subscription with the underlying error from the stream. | ||
| assert!(matches!(sub.next().await, Some(Err(Error::SubscriptionClosed(close_reason))) if close_reason == exp)); |
There was a problem hiding this comment.
Is it worth just calling sub.next().await once more after this to confirm that it's None and that the thing definitely won't send any more?
There was a problem hiding this comment.
yeah, just found a bug let's tackle it another PR.
jsdw
approved these changes
Mar 31, 2022
niklasad1
changed the title
pipe_from_stream take stream of resultpipe_from_try_stream to support streams that returns Result
niklasad1
changed the title
pipe_from_try_stream to support streams that returns ResultSubscriptionSink::pipe_from_try_stream to support streams that returns Result
niklasad1
commented
Apr 1, 2022
niklasad1
commented
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale for this is that it is more flexible for use cases when
Stream<Item = Result<T, Error>>.Take for example
tokio_stream::Broadcastthen one would have to something like:Note, I realized that
pipe_from_streamwill work if Error: Serialize bound is satisfied but that's unlikely for the error types but I added a comment about that