fix(ws client): improve error message bad URL #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
reviewed
Jan 6, 2022
client/transport/src/ws/mod.rs
Outdated
Comment on lines
442
to
444
| let err = format!("{:?} not supported, expects 'ws' or 'wss'", invalid_scheme); | ||
| #[cfg(not(feature = "tls"))] | ||
| let err = "URL scheme not supported, expects 'ws'"; | ||
| let err = format!("{:?} not supported, expects 'ws' ('wss' requires the tls feature)", invalid_scheme); |
There was a problem hiding this comment.
This will print something like Some("http") not supported, expects 'ws' or 'wss'; are we happy with that or would it be better to maybe do something like invalid_scheme.unwrap_or("no scheme")?
There was a problem hiding this comment.
Right, I think your suggestion is better.
jsdw
approved these changes
Jan 6, 2022
maciejhirsz
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/improves the error message when a bad URL is detected
Partly addresses #638 to print an error when an absolute URI
in a redirection couldn't be parsed as a WS target.