-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove direct tracing calls from proc-macros #1405
Conversation
6ff1cc7
to
ae27f81
Compare
ae27f81
to
2f216b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Hey @niklasad1 anything left to do here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One thing I wonder is; how do we avoid regressing again in this area? Maybe worth adding a CI check which expands some macros and logs the lines or something, so we get a feeling for changes over time and can note any large differences.
This significantly reduces the amount of code generated by the
rpc
macro.I've also taken the liberty to refactor some of the proc macro code to make it more maintainable.
For example, on the
reth-rpc-api
crate (just#[rpc(server)]
):cargo expand
: 156,020 LoCcargo check -p
aftercargo clean -p
: 3.1scargo expand
: 73,276 LoCcargo check -p
aftercargo clean -p
: 1.7s