refactor(client): remove MaxSlots limit #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
approved these changes
May 23, 2024
lexnv
approved these changes
May 24, 2024
|
When is new release planned? I'd love to upgrade to use this |
|
Hey, we are planning a new breaking release 0.23/1.0 soon hopefully next week but it has some big changes such as moving to hyper v1.0 and I need to do some manually testing on it.... |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1374
The rationale behind this is that the "ws-client/async-client" already has a bounded channel which provides backpressure and it doesn't make sense to use slot limit to throw an error if it's exceeded.
For the http client it's another story where it's handled by the hyper threadpool and we have no channel that provides backpressure.
However, it's better that users themselves decide how many concurrent calls that they want...