Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: change ws ping API #1248

Merged
merged 9 commits into from
Dec 1, 2023
Merged

server: change ws ping API #1248

merged 9 commits into from
Dec 1, 2023

Conversation

niklasad1
Copy link
Member

Close #1195

@niklasad1 niklasad1 requested a review from a team as a code owner November 29, 2023 17:26

Verified

This commit was signed with the committer’s verified signature.
niklasad1 Niklas Adolfsson

Verified

This commit was signed with the committer’s verified signature.
niklasad1 Niklas Adolfsson
server/src/server.rs Outdated Show resolved Hide resolved
server/src/server.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👍

Verified

This commit was signed with the committer’s verified signature.
niklasad1 Niklas Adolfsson

Verified

This commit was signed with the committer’s verified signature.
niklasad1 Niklas Adolfsson

Verified

This commit was signed with the committer’s verified signature.
niklasad1 Niklas Adolfsson

Verified

This commit was signed with the committer’s verified signature.
niklasad1 Niklas Adolfsson
server/src/server.rs Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@niklasad1 niklasad1 changed the title feat(server): make it possible to disable WS ping server: change ws ping API Dec 1, 2023
server/src/transport/ws.rs Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@tadeohepperle tadeohepperle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the changes to PingConfig :)

server/src/server.rs Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@niklasad1 niklasad1 merged commit 80902d3 into master Dec 1, 2023
11 checks passed
@niklasad1 niklasad1 deleted the fix-1195 branch December 1, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[server]: add configuration to disable periodic Websocket Ping
3 participants