Fix Params deserialization on serde_json>=1.0.8 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to serde-rs/json#389, serde_json no longer calls `deserialize_any` in `deserialize_identifer` (and all other default implemented methods). This causes `Params` to fail to deserialize maps and sequences since it has hinted that it expects an identifier. This implements `deserialize` correctly, saying that it accepts any type.
|
Hi @Marwes! Thanks a bunch. Would you mind adding a test to cover current incorrect behaviour? |
|
It should be covered by https://github.com/Marwes/jsonrpc/blob/9d6fcf1aa9d4f3b2eb174f83b4785284501976f8/core/src/types/params.rs#L98-L110 . It is just that the last build of jsonrpc-core was with serde_json<1.0,8. (Also I couldn't build this locally due to rust-lang/cargo#4810 so I just opted for the minimal change through the github gui :/ ) |
|
Looks to be building with 1.0.8 so if it passes this should be good https://travis-ci.org/paritytech/jsonrpc/jobs/316075816#L491 |
|
I see, thanks! Will try to bump in my local Cargo.lock and test. |
|
Same issue for |
tomusdrw
approved these changes
Dec 13, 2017
debris
pushed a commit
that referenced
this pull request
Jan 15, 2018
* Fix Params deserialization on serde_json>=1.0.8 Due to serde-rs/json#389, serde_json no longer calls `deserialize_any` in `deserialize_identifer` (and all other default implemented methods). This causes `Params` to fail to deserialize maps and sequences since it has hinted that it expects an identifier. This implements `deserialize` correctly, saying that it accepts any type. * Fix Id deserialization on serde_json>=1.0.8
Merged
debris
added a commit
that referenced
this pull request
Jan 15, 2018
* Fix Params deserialization on serde_json>=1.0.8 Due to serde-rs/json#389, serde_json no longer calls `deserialize_any` in `deserialize_identifer` (and all other default implemented methods). This causes `Params` to fail to deserialize maps and sequences since it has hinted that it expects an identifier. This implements `deserialize` correctly, saying that it accepts any type. * Fix Id deserialization on serde_json>=1.0.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to serde-rs/json#389, serde_json no longer calls
deserialize_anyindeserialize_identifer(and all other default implemented methods). This causesParamsto fail to deserialize maps and sequences since it has hinted that it expects an identifier.This implements
deserializecorrectly, saying that it accepts any type.cc @dtolnay (thought you might want to be aware of this regression/bug)