Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable overflow checks for examples #1034

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Disable overflow checks for examples #1034

merged 1 commit into from
Nov 23, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Nov 23, 2021

Until #364 is resolved once again.

HCastano
HCastano approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a follow-up PR to cargo-contract as well for the flipper template

@cmichi cmichi merged commit b2256d9 into master Nov 23, 2021
@cmichi cmichi deleted the cmichi-bring-back-overflow-checks branch November 23, 2021 12:49
This was referenced Nov 23, 2021
Closed
Merged
@HCastano HCastano mentioned this pull request Nov 23, 2021
Closed
athei added a commit that referenced this pull request Nov 25, 2021
@athei
Revert "Disable overflow checks for examples (#1034)"
05848f6 
This reverts commit b2256d9.
cmichi pushed a commit that referenced this pull request Nov 26, 2021
@athei
Explicitly link against rlibc to get non buggy version of memcpy (#1049)
fb86286 
* Explicitly link against rlibc to get non-buggy version of memcpy

* Revert "Disable overflow checks for examples (#1034)"

This reverts commit b2256d9.
@mmagician mmagician mentioned this pull request Jan 19, 2022
Merged
5 tasks
xgreenx pushed a commit to Supercolony-net/ink that referenced this pull request Feb 8, 2022
@xgreenx
Disable overflow checks for examples (use-ink#1034)
9c42bce
xgreenx pushed a commit to Supercolony-net/ink that referenced this pull request Feb 8, 2022
@athei @xgreenx
Explicitly link against rlibc to get non buggy version of memcpy (use…
234dbf9 
…-ink#1049)

* Explicitly link against rlibc to get non-buggy version of memcpy

* Revert "Disable overflow checks for examples (use-ink#1034)"

This reverts commit b2256d9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HCastano HCastano HCastano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmichi @HCastano