Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pass that removes spurious panic import function #369

Closed
athei opened this issue Nov 23, 2021 · 2 comments
Closed

Add pass that removes spurious panic import function #369

athei opened this issue Nov 23, 2021 · 2 comments
Assignees

Comments

@athei
Copy link
Contributor

athei commented Nov 23, 2021

In order to resolve use-ink/ink#364 we should add a pass that removes the imported function and replaces all call sides by an unreachable instruction. This is OK because we assume that the intention of calling this function is to panic anyways.

It might prevent unwinding in cases that is enabled. However, we don't support unwinding anyways so it does not matter.

@athei athei self-assigned this Nov 23, 2021
@cmichi
Copy link
Collaborator

cmichi commented Nov 23, 2021

As part of this issue the effect of those two PR's should be revoked:
use-ink/ink#1034
#372

@athei
Copy link
Contributor Author

athei commented Nov 26, 2021

Replaced by use-ink/ink#1049

@athei athei closed this as completed Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants