Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to run new feature: light client mode #300

Merged
merged 8 commits into from
Sep 11, 2023
Merged

Conversation

lazam
Copy link
Contributor

@lazam lazam commented Sep 6, 2023

To support a new feature of Substrate to run the node as light client mode in this PR

charts/node/values.yaml Outdated Show resolved Hide resolved
@bakhtin
Copy link
Contributor

bakhtin commented Sep 6, 2023

Please, make sure to re-run pre-commit hooks to fix the README

diff --git a/charts/node/README.md b/charts/node/README.md
index bec6285..7bcd811 100644
--- a/charts/node/README.md
+++ b/charts/node/README.md
@@ -375,7 +375,7 @@ If you're running a collator node:
 | node.lightClientMode | object | `{"enabled":false,"relayChain":"","relayChainCustomChainspecPath":"","relayChainCustomChainspecUrl":""}` | EXPERIMENTAL!!! Run the collator node without a relay chain via light client ref: https://github.com/paritytech/cumulus/pull/2270 Enabling this option will disable the values of collatorRelayChain |
 | node.lightClientMode.enabled | bool | `false` | Enable deployment of the external collator |
 | node.lightClientMode.relayChain | string | `""` | Name of the Relay Chain to connect |
-| node.lightClientMode.relayChainCustomChainspecPath | string | `""` | Path to the file containing the chainspec of the collator relay-chain Set to /chain-data instead of /relaychain-data to avoid  deploying uncessary persitent volume |
+| node.lightClientMode.relayChainCustomChainspecPath | string | `""` | Path to the file containing the chainspec of the collator relay-chain Set to /chain-data instead of /relaychain-data to avoid deploying uncessary persitent volume |
 | node.lightClientMode.relayChainCustomChainspecUrl | string | `""` | URL to retrive custom chain spec |
 | node.logLevels | list | `[]` | Log level |
 | node.perNodeServices | object | `{"apiService":{"annotations":{},"enabled":true,"externalDns":{"customPrefix":"","enabled":false,"hostname":"example.com","ttl":300},"externalTrafficPolicy":"Cluster","httpPort":9933,"prometheusPort":9615,"relayChainPrometheusPort":9625,"rpcPort":9944,"type":"ClusterIP","wsPort":9955},"paraP2pService":{"annotations":{},"enabled":false,"externalDns":{"customPrefix":"","enabled":false,"hostname":"example.com","ttl":300},"externalTrafficPolicy":"Cluster","port":30334,"type":"NodePort","ws":{"enabled":false,"port":30335}},"relayP2pService":{"annotations":{},"enabled":false,"externalDns":{"customPrefix":"","enabled":false,"hostname":"example.com","ttl":300},"externalTrafficPolicy":"Cluster","port":30333,"type":"NodePort","ws":{"enabled":false,"port":30334}},"setPublicAddressToExternalIp":{"enabled":false,"ipRetrievalServiceUrl":"https://ifconfig.io"}}` | Configuration of individual services of the node |

charts/node/values.yaml Outdated Show resolved Hide resolved
@lazam
Copy link
Contributor Author

lazam commented Sep 7, 2023

I renamed the two different modes to collatorExternalRelayChain and collatorLightClient to match the same convention of the collatorRelaychain.

charts/node/values.yaml Show resolved Hide resolved
charts/node/templates/statefulset.yaml Outdated Show resolved Hide resolved
@lazam lazam merged commit 9131b92 into main Sep 11, 2023
2 checks passed
@lazam lazam deleted the al-light-client-mode branch September 11, 2023 08:50
--listen-addr=/ip4/0.0.0.0/tcp/30333 \
{{- end }}

{{- end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this {{- end }} up:
Before:

--parachain flags 
{{- if and .Values.node.isParachain (not .Values.node.externalRelayChain.enabled) }}
-- \ 
--relaychain flags
{{- end }}
--common flags  (parachain+relaychain)

Now:

--parachain flags 
{{- if and .Values.node.isParachain (not .Values.node.externalRelayChain.enabled) }}
-- \ 
--new relaychain flags
{{- if  not .Values.node.collatorLightClient.enabled }}
--relaychain flags
{{- end }}
--common flags  (parachain+relaychain)
{{- end }}

expected:

--parachain flags 
{{- if and .Values.node.isParachain (not .Values.node.externalRelayChain.enabled) }}
-- \ 
--new relaychain flags
{{- if  not .Values.node.collatorLightClient.enabled }}
--relaychain flags
{{- end }}
{{- end }}
--common flags  (parachain+relaychain)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants