-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to run new feature: light client mode #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BulatSaif
reviewed
Sep 6, 2023
BulatSaif
reviewed
Sep 6, 2023
Please, make sure to re-run pre-commit hooks to fix the README diff --git a/charts/node/README.md b/charts/node/README.md
index bec6285..7bcd811 100644
--- a/charts/node/README.md
+++ b/charts/node/README.md
@@ -375,7 +375,7 @@ If you're running a collator node:
| node.lightClientMode | object | `{"enabled":false,"relayChain":"","relayChainCustomChainspecPath":"","relayChainCustomChainspecUrl":""}` | EXPERIMENTAL!!! Run the collator node without a relay chain via light client ref: https://github.com/paritytech/cumulus/pull/2270 Enabling this option will disable the values of collatorRelayChain |
| node.lightClientMode.enabled | bool | `false` | Enable deployment of the external collator |
| node.lightClientMode.relayChain | string | `""` | Name of the Relay Chain to connect |
-| node.lightClientMode.relayChainCustomChainspecPath | string | `""` | Path to the file containing the chainspec of the collator relay-chain Set to /chain-data instead of /relaychain-data to avoid deploying uncessary persitent volume |
+| node.lightClientMode.relayChainCustomChainspecPath | string | `""` | Path to the file containing the chainspec of the collator relay-chain Set to /chain-data instead of /relaychain-data to avoid deploying uncessary persitent volume |
| node.lightClientMode.relayChainCustomChainspecUrl | string | `""` | URL to retrive custom chain spec |
| node.logLevels | list | `[]` | Log level |
| node.perNodeServices | object | `{"apiService":{"annotations":{},"enabled":true,"externalDns":{"customPrefix":"","enabled":false,"hostname":"example.com","ttl":300},"externalTrafficPolicy":"Cluster","httpPort":9933,"prometheusPort":9615,"relayChainPrometheusPort":9625,"rpcPort":9944,"type":"ClusterIP","wsPort":9955},"paraP2pService":{"annotations":{},"enabled":false,"externalDns":{"customPrefix":"","enabled":false,"hostname":"example.com","ttl":300},"externalTrafficPolicy":"Cluster","port":30334,"type":"NodePort","ws":{"enabled":false,"port":30335}},"relayP2pService":{"annotations":{},"enabled":false,"externalDns":{"customPrefix":"","enabled":false,"hostname":"example.com","ttl":300},"externalTrafficPolicy":"Cluster","port":30333,"type":"NodePort","ws":{"enabled":false,"port":30334}},"setPublicAddressToExternalIp":{"enabled":false,"ipRetrievalServiceUrl":"https://ifconfig.io"}}` | Configuration of individual services of the node | |
BulatSaif
reviewed
Sep 6, 2023
I renamed the two different modes to |
BulatSaif
approved these changes
Sep 7, 2023
PierreBesson
reviewed
Sep 8, 2023
BulatSaif
reviewed
Sep 11, 2023
--listen-addr=/ip4/0.0.0.0/tcp/30333 \ | ||
{{- end }} | ||
|
||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this {{- end }}
up:
Before:
--parachain flags
{{- if and .Values.node.isParachain (not .Values.node.externalRelayChain.enabled) }}
-- \
--relaychain flags
{{- end }}
--common flags (parachain+relaychain)
Now:
--parachain flags
{{- if and .Values.node.isParachain (not .Values.node.externalRelayChain.enabled) }}
-- \
--new relaychain flags
{{- if not .Values.node.collatorLightClient.enabled }}
--relaychain flags
{{- end }}
--common flags (parachain+relaychain)
{{- end }}
expected:
--parachain flags
{{- if and .Values.node.isParachain (not .Values.node.externalRelayChain.enabled) }}
-- \
--new relaychain flags
{{- if not .Values.node.collatorLightClient.enabled }}
--relaychain flags
{{- end }}
{{- end }}
--common flags (parachain+relaychain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support a new feature of Substrate to run the node as light client mode in this PR