convert to using frame-metadata crate everywhere
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
changed the title
frame-metadata crate everywhereframe-metadata crate everywhere
insipx
changed the title
frame-metadata crate everywhereframe-metadata crate everywhere
insipx
commented
Oct 22, 2021
TarikGul
approved these changes
Oct 22, 2021
dvdplm
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gets rid of
substrate_metadata_versions.rel paritytech/frame-metadata#27
Not going to be merged until frame metadata releases a version that includes v8-v11, so that we can make the versions in v14 and legacy codepaths the same.it would be really useful for the facade crate if both core and core_v14 used the same frame-metadata version