[WIP] Integrate v14 to txdecoder #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Oct 12, 2021
bin/tx-decoder/src/decoder.rs
Outdated
| if self.is_version_new(version) { | ||
| let decoder = self.new.get(&version.try_into()?).ok_or_else(|| anyhow!("version {} not found for new decoder", version))?; | ||
| let ext = decoder.decode_extrinsics(data)?; | ||
| // Ok(serde_json::to_string_pretty(&ext)?) |
There was a problem hiding this comment.
do you mean for serde_json?
There was a problem hiding this comment.
I meant to say that I assume this line is here for debugging purposes, to see the xt pretty printed, which seems useful. So maybe it could become a trace level log.
There was a problem hiding this comment.
Ah yeah, it is. I actually just left it here to remind me to uncomment it at some point -- the output of decode_extrinsics in v14 doesn't impl Serialize/Deserialize yet. That's why i return a formatted debug log instead. I'll make this a WIP PR because it won't be merged until after v14 stuff is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some quick testing!
this is a pretty quick&dirty impl/PoC (kindof created a poc decoder facade too i guess) for tx-decoder