Update dependencies and get things compiling/passing CI again. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
changed the title
jsdw
changed the title
tadeohepperle
approved these changes
Oct 31, 2023
niklasad1
reviewed
Oct 31, 2023
|
|
||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | ||
|
|
||
| [dependencies] | ||
| desub = { path = "../../desub", features = [ "polkadot-js" ] } | ||
| desub = { workspace = true, features = [ "polkadot-js" ] } |
There was a problem hiding this comment.
yeah I don't like the spaces around the features but could be taken care of in another PR
There was a problem hiding this comment.
Ooh yeah me neither :)
niklasad1
reviewed
Oct 31, 2023
| pub enum Conviction { | ||
| /// 0.1x votes, unlocked. | ||
| #[default] |
niklasad1
reviewed
Oct 31, 2023
| @@ -25,6 +25,7 @@ pub fn mock_runtime(num: u32) -> RuntimeVersion { | |||
| spec_version: num, | |||
| impl_version: num, | |||
| apis: Cow::from(Vec::new()), | |||
| transaction_version: 4, | |||
There was a problem hiding this comment.
Why changed?
Does scale-value need newer metadata or something?
There was a problem hiding this comment.
Oh, I just didn't like that it was 4, which is identical to the version of the tx protocol (which is a different version, so easy to confuse the two!), so I set it to the version from polkadot iirc
niklasad1
approved these changes
Oct 31, 2023
lexnv
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scale-valueandscale-decodein place of the built-in Value type.