This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use Polkadot Constants instead of Hardcoding #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apopiak please review |
apopiak
reviewed
Jan 4, 2022
There was a problem hiding this comment.
Thanks for your contribution!
I don't agree with your particular approach here:
We want to keep the constants.rs modules in the runtimes, we just want to define the values by using the relay chain constants instead of them being hard-coded.
So I would ask you to re-add the removed modules.
Neither the client code (chain_spec.rs) nor the runtime lib.rs files should need to change.
apopiak
added
A0-pleasereview
B0-silent
KiChjang
reviewed
Jan 11, 2022
KiChjang
reviewed
Jan 11, 2022
KiChjang
reviewed
Jan 11, 2022
apopiak
reviewed
Jan 11, 2022
Co-authored-by: Alexander Popiak <[email protected]>
|
@Doordashcon i think you need to update your rust compiler to make the rustfmt match up here |
bkchr
approved these changes
Jan 13, 2022
|
bot merge |
|
Got a notification by @gilescope about a tip? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #860
polkadot companion: paritytech/polkadot#4561
polkadot address: 12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h