Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add build with docker info to README #609

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Add build with docker info to README #609

merged 3 commits into from
Sep 16, 2021

Conversation

alvicsam
Copy link
Contributor

Added information about how to build and test the code with a docker image that is used in our pipelines. (Related to https://github.com/paritytech/ci_cd/issues/113)

Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make it a little simpler but no big issues.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good once the additionnal missing --locked you spoted has been added.

@alvicsam
Copy link
Contributor Author

@chevdor unfortunately I can't merge changes (the button is inactive), tests are failing. I restarted them several times but with no luck (interesting thing it that each time different tests are failing)

@chevdor
Copy link
Contributor

chevdor commented Sep 16, 2021

@alvicsam yes I saw that. I just approved again after checking that you did the last changes we talked about.
Don't worry about it the build failing. Your PR has nothing to do with it.
This will be fixed or your PR will be merged "as is". We just need to be patient :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants