Add Transaction Fee RPC to Statemint/Statemine #559
Conversation
Co-authored-by: Bastian Köcher <[email protected]>
polkadot-parachains/src/rpc.rs
Outdated
| /// Alias to 512-bit hash when used in the context of a transaction signature on the chain. | ||
| pub type Signature = sp_runtime::MultiSignature; | ||
| /// Some way of identifying an account on the chain. We intentionally make it equivalent | ||
| /// to the public key of our transaction signing scheme. | ||
| pub type AccountId = <<Signature as sp_runtime::traits::Verify>::Signer as sp_runtime::traits::IdentifyAccount>::AccountId; | ||
| type BlockNumber = u32; | ||
| type Header = sp_runtime::generic::Header<BlockNumber, sp_runtime::traits::BlakeTwo256>; | ||
| pub type Block = sp_runtime::generic::Block<Header, sp_runtime::OpaqueExtrinsic>; | ||
| type Balance = u128; | ||
| type Nonce = u32; |
There was a problem hiding this comment.
i dont think this is right either. shouldnt be that we are redefining all these types here.
should make the function generic over these types, or properly import them
There was a problem hiding this comment.
Moved them to primitives module and imported the common primitives in rpc.rs and service.rs.
|
Is there any way we can move this along please? What can we do to help? This is a huge blocker for us. |
| pub type Signature = sp_runtime::MultiSignature; | ||
| /// Some way of identifying an account on the chain. We intentionally make it equivalent | ||
| /// to the public key of our transaction signing scheme. | ||
| pub type AccountId = <<Signature as sp_runtime::traits::Verify>::Signer as sp_runtime::traits::IdentifyAccount>::AccountId; | ||
| pub type BlockNumber = u32; | ||
| pub type Header = sp_runtime::generic::Header<BlockNumber, sp_runtime::traits::BlakeTwo256>; | ||
| pub type Block = sp_runtime::generic::Block<Header, sp_runtime::OpaqueExtrinsic>; | ||
| pub type Hash = sp_core::H256; | ||
| pub type Balance = u128; | ||
| pub type Nonce = u32; |
There was a problem hiding this comment.
I made #577 as an improvement to this file.
There was a problem hiding this comment.
Also in the future, need to add the copyright headers when adding new files, fyi
* rename to parachains-common * refactor shared opaque * remove primitives
|
bot merge |
|
Error getting Process.json: |
|
bot merge |
|
Error getting Process.json: |
|
Hi, is there a specific reason why this wasn't included in the V3 release? |
|
@Swader it was just merged, and release process was already in the pipeline. It will be included in the next release. In the meantime, it would be nice to get your confirmation that the RPC and all behaviors are working as expected on a local test net. |
|
Sure, I will test our distribution script locally and report back |
* add payment rpc to parachains * connect payment rpc to parachains clients * fix the rumtime_api bound/ add separate start node implementation for shell * use cumulus/parachain specific primitives * Update polkadot-parachains/src/rpc.rs Co-authored-by: Bastian Köcher <[email protected]> * rename txpool dependency * fix the package name * move parachain primitives to separate module * Refactor Shared Primitves for Payment Info (#577) * rename to parachains-common * refactor shared opaque * remove primitives * Update service.rs Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Shawn Tabrizi <[email protected]>
|
Hi, is there a specific date the next release of statemint including this request ? |
This will be in the next Statemine/mint release which will happen after the polkadot release. Next polkadot release is about to start, so hopefully soon after that this should be available on statemint. |
changes to add the support for payment rpc to parachains to address #542