This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 378
Run all benchmarks "as tests" in short setup on every PR #2846
Merged
Merged
Changes from 6 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
f52e70b
Run all benchmarks "as tests" in short setup on every PR
bkontur 6d58d27
Fix
bkontur fc9ffa4
Update scripts/ci/gitlab/pipeline/short-benchmarks.yml
bkontur 0c2e008
Updated TODO
bkontur 17827d5
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
78002bd
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
644c3f2
Removed `--execution wasm`
bkontur c639bb8
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
bkontur 1690316
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
bkontur dee4513
[asset-conv] Unused Balances type
bkontur 9baf9f6
[asset-conv] native asset change
bkontur c40cba3
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
bkontur 0c1aedb
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
bkontur e93fecc
Dedicated `AssetBalance` type for `pallet_assets` instances
bkontur f40746f
Improved local vs foreign asset handling + test for not allowing pool…
bkontur 2145285
Removed `into_multiasset_id`
bkontur 70daf3b
Fix
bkontur 1f6c814
Refactor
bkontur fcece4c
Fixed create_pool for benchmark with LocalAndForeignAssets (finally f…
bkontur 82ffbb2
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
bkontur d9636dc
Revert
bkontur 6a19ff0
fmt
bkontur 1d82b31
Migrates pools with `MultiLocation { parents: 0, interior: Here }` to…
bkontur fb101a3
Allow `set_storage` for `AllowMultiAssetPools` / `LiquidityWithdrawal…
bkontur 58db05f
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
bkontur 84547be
Benchmarks work
bkontur 8a4c351
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
bkontur f05cd2e
Removed comment + more defensive migration
bkontur c79882b
`T::Currency::transfer` -> `Balances::transfer_all` in migration
bkontur e3c3b83
Change pool_id in migration
bkontur a5af430
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
bkontur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| # This file is part of .gitlab-ci.yml | ||
| # Here are all jobs that are executed during "short-benchmarks" stage | ||
|
|
||
| # Run all pallet benchmarks only once to check if there are any errors | ||
| .short-benchmark-template: &short-bench | ||
| stage: short-benchmarks | ||
| extends: | ||
| - .common-refs | ||
| - .docker-env | ||
| needs: | ||
| - job: build-short-benchmark | ||
| artifacts: true | ||
| variables: | ||
| RUNTIME_CHAIN: benchmarked-runtime-chain | ||
| script: | ||
| - ./artifacts/polkadot-parachain benchmark pallet --execution wasm --wasm-execution compiled --chain $RUNTIME_CHAIN --pallet "*" --extrinsic "*" --steps 2 --repeat 1 | ||
|
|
||
| short-benchmark-asset-hub-polkadot: | ||
| <<: *short-bench | ||
| variables: | ||
| RUNTIME_CHAIN: asset-hub-polkadot-dev | ||
|
|
||
| short-benchmark-asset-hub-kusama: | ||
| <<: *short-bench | ||
| variables: | ||
| RUNTIME_CHAIN: asset-hub-kusama-dev | ||
|
|
||
| short-benchmark-asset-hub-westend: | ||
| <<: *short-bench | ||
| variables: | ||
| RUNTIME_CHAIN: asset-hub-westend-dev | ||
|
|
||
| short-benchmark-bridge-hub-polkadot: | ||
| <<: *short-bench | ||
| variables: | ||
| RUNTIME_CHAIN: bridge-hub-polkadot-dev | ||
|
|
||
| short-benchmark-bridge-hub-kusama: | ||
| <<: *short-bench | ||
| variables: | ||
| RUNTIME_CHAIN: bridge-hub-kusama-dev | ||
|
|
||
| short-benchmark-bridge-hub-rococo: | ||
| <<: *short-bench | ||
| variables: | ||
| RUNTIME_CHAIN: bridge-hub-rococo-dev | ||
|
|
||
| short-benchmark-collectives-polkadot : | ||
| <<: *short-bench | ||
| variables: | ||
| RUNTIME_CHAIN: collectives-polkadot-dev | ||
|
|
||
| short-benchmark-glutton-kusama : | ||
| <<: *short-bench | ||
| variables: | ||
| RUNTIME_CHAIN: glutton-kusama-dev-1300 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this one is automatically creating a MR to update the weights? I dont know if that is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, but it works only with
release-parachains-v*branches. Last time it was used month agoThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggwpez yes, it is used for the releases, when the benchmark job is triggered from git lab. We used to do it manually so far
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EgorPopelyaev @ggwpez @joepetrowski @chevdor @alvicsam @bkchr
so for the very next release to regenerate weights, do we want to use:
bot bench $ all?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkontur lets's proceed with the new
botsolution if it does a thing, but I would still keep the old pipeline yaml, as a plan B. At least for the next releaseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EgorPopelyaev ok, good point