-
Notifications
You must be signed in to change notification settings - Fork 378
Co #14338: pallet-glutton
: over-unity consumption
#2730
Conversation
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
bot fmt |
@NachoPal https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2977408 was started for your command Comment |
@NachoPal Command |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
If the actual spent PoV depends on benchmarked weights. Does it mean we shouldn't regenerate the Weights for this calculations to remain correct? |
Yea I will call the benchbot, thanks for noticing. PS: The upstream CI is green now, so this MR should be good. |
The runtime is using local weights though. If you want to update them you should run the benchbot also here |
I hope weights are updated prior to releases anyway? |
Maybe I can also diener it and call the bot directly here, will try. |
Yes, they will be, but we are not waiting for next release to deploy Gluttons, we get the runtime from I would just leave the weights as they are. |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Merge cancelled due to error. Error: Command 'Command { std: cd "/storage/repositories/cumulus" && "git" "push" "paritytech" "oty-glutton-overunity", kill_on_drop: false }' failed with status Some(1); output: To https://github.com/paritytech/cumulus.git |
bot merge The bot did not try to update. So doing it manually now. |
Waiting for commit status. |
Companion for paritytech/substrate#14338
Change:
Perbill
toFixedU64
*_percent
to*_ratio