Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Serialize/Deserialize trait implemented in no-std for numerous types #2660

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Serialize/Deserialize trait implemented in no-std for numerous types #2660

merged 5 commits into from
Jun 1, 2023

Conversation

michalkucharczyk
Copy link
Contributor

@michalkucharczyk michalkucharczyk commented May 31, 2023 •
edited
Loading

serde feature was NOT introduced into updated crates.

Required for paritytech/polkadot-sdk#25

Companion for: paritytech/substrate#14261

This was referenced May 31, 2023
Merged
Merged
@michalkucharczyk michalkucharczyk added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 31, 2023
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2924108

@michalkucharczyk michalkucharczyk requested a review from a team May 31, 2023 15:27
@michalkucharczyk michalkucharczyk marked this pull request as ready for review May 31, 2023 15:27
@paritytech-ci paritytech-ci requested a review from a team May 31, 2023 15:27
melekes
melekes approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for f9af8f4

@michalkucharczyk
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Jun 1, 2023 •
edited
Loading

@michalkucharczyk https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2930153 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 53-6317b730-4fd7-42a3-99a4-49475023cafa to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 1, 2023

@michalkucharczyk Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2930153 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2930153/artifacts/download.

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 9d6cc05

@lexnv lexnv mentioned this pull request Jun 1, 2023
Merged
@niklasad1 niklasad1 merged commit d6e4269 into master Jun 1, 2023
@niklasad1 niklasad1 deleted the mku-serialize-added-for-some-types branch June 1, 2023 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@serban300 serban300 serban300 approved these changes

@davxy davxy davxy approved these changes

@melekes melekes melekes approved these changes

@bkchr bkchr Awaiting requested review from bkchr

@acatangiu acatangiu Awaiting requested review from acatangiu

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michalkucharczyk @paritytech-cicd-pr @melekes @davxy @serban300 @niklasad1