Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Runtime: Polkadot Fellowship promotion/demotion periods, members activity and salaries #2607

Merged
merged 32 commits into from
Jun 6, 2023

Conversation

muharem
Copy link
Contributor

@muharem muharem commented May 20, 2023

Additional logic for the Polkadot Technical Fellowship:

  • promotion period - the minimum period for a member before they can be promoted to the next rank;
  • demotion periods - the period following which a member may be a subject to demotion if no evidence supporting the re-approval of their rank is presented;
  • members activity/passivity;
  • members salaries.

Every existing ranked member needs to be manually imported into the core fellowship pallet for the new logic to be applied. New members who are inducted through the core fellowship pallet have the new logic from the start.

For more information on the continuation rules, members' activity/passivity, and the promotion period, refer to the Polkadot Fellowship Manifesto (4.3 Continuation, 4.6 Notes).

The additional settings are set and serviced via fellowship core pallet, for more information refer to the pallet's documentation. Periodical payouts managed via salary pallet.

fixes #2577

TODO

  • discuss and agree on the following parameters - RegistrationPeriod, PayoutPeriod, Budget.
  • Determine the SovereignAccountId for (Parent, Parachain(1001), PalletInstance(64)) on Statemint

Later

  • Fund 13w7NdvSR1Af8xsQTArDtZmVvjE8XhWNdL4yed3iFHrUNCnS with USDT.

@muharem muharem marked this pull request as ready for review May 20, 2023 14:15
@paritytech-ci paritytech-ci requested review from a team May 20, 2023 14:16
@muharem muharem added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. T1-runtime This PR/Issue is related to the topic “runtime”. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 20, 2023
@muharem muharem changed the title Core Fellowship Polkadot Fellowship promotion/demotion periods, members activity and salaries May 20, 2023
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
IIUC the salary at al can be set after deployment by an extrinsic.

@muharem muharem added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels May 23, 2023
@gavofyork gavofyork changed the title Polkadot Fellowship promotion/demotion periods, members activity and salaries Runtime: Polkadot Fellowship promotion/demotion periods, members activity and salaries May 25, 2023
@paritytech-ci paritytech-ci requested a review from a team June 2, 2023 17:03
@muharem
Copy link
Contributor Author

muharem commented Jun 4, 2023

requires this change for PayOverXcm type paritytech/polkadot#7327

@muharem
Copy link
Contributor Author

muharem commented Jun 5, 2023

working on a test for PayOverXcm setup, the test based on xcm-emulator

@gavofyork
Copy link
Member

@bkchr @joepetrowski going to need a cumulus locks review here...

@gavofyork
Copy link
Member

@muharem @joepetrowski @bkontur final review/approval?

@muharem
Copy link
Contributor Author

muharem commented Jun 5, 2023

@gavofyork I cannot approve since I am a creator of the PR. But all the changes look good to me.

@ggwpez
Copy link
Member

ggwpez commented Jun 5, 2023

@joepetrowski is offline on vacation afaik.

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not go into every detail, but the overall configuration looks good to me. 👍

@gavofyork gavofyork merged commit f2d66a2 into master Jun 6, 2023
@gavofyork gavofyork deleted the muharem-core-fellowship branch June 6, 2023 10:48
@louismerlin louismerlin added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited. and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Integrate Core Fellowship logic into Collectives chain
8 participants