-
Notifications
You must be signed in to change notification settings - Fork 378
Conversation
bench $ pallet statemine-dev pallet_nfts |
type CollectionId = u32; | ||
type ItemId = u32; | ||
type Currency = Balances; | ||
type CreateOrigin = AsEnsureOriginWithArg<EnsureSigned<AccountId>>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should allow foreign origins as well, so that collectives can create collections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could also be an upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do this as an upgrade once we get to the integration with collectives
pallet_nfts::Call::set_attribute { .. } | | ||
pallet_nfts::Call::force_set_attribute { .. } | | ||
pallet_nfts::Call::clear_attribute { .. } | | ||
pallet_nfts::Call::approve_item_attributes { .. } | | ||
pallet_nfts::Call::cancel_item_attributes_approval { .. } | | ||
pallet_nfts::Call::set_metadata { .. } | | ||
pallet_nfts::Call::clear_metadata { .. } | | ||
pallet_nfts::Call::set_collection_metadata { .. } | | ||
pallet_nfts::Call::clear_collection_metadata { .. } | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these have bounds on their encoded size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, none of those methods accept unbounded vecs, only the bounded ones
@@ -632,6 +686,7 @@ construct_runtime!( | |||
// The main stage. | |||
Assets: pallet_assets::<Instance1>::{Pallet, Call, Storage, Event<T>} = 50, | |||
Uniques: pallet_uniques::{Pallet, Call, Storage, Event<T>} = 51, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so Uniques: pallet_uniques
stays or any migration to nfts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's going to stay for now until we get the UI support for the new pallet and make a decision on the proper migration path
type StringLimit = ConstU32<256>; | ||
type KeyLimit = ConstU32<64>; | ||
type ValueLimit = ConstU32<256>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a rationale how those numbers were chosen and why they are different between pallet_uniques
and pallet_nfts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I didn't want to change anything in pallet uniques
- in real apps it's very hard to fit anything in 32/64 bytes. Since users will put a deposit as per byte, I think it's safe to allow them to store up to 256 bytes of data in one attribute
bot merge |
* Add nfts pallet to statemine * Add missing trait * Add nfts pallet to SafeCallFilter * Re-use uniques deposits
* master: Companion for #13624 (#2354) Introduce Fellowship into Collectives (#2186) NFTs 2.0 on Statemine (#2314) Bump assert_cmd from 2.0.8 to 2.0.10 (#2341) Bump clap from 4.1.8 to 4.1.11 (#2352) Companion for substrate #13312: Rename `Deterministic` to `Enforce` (#2350) [Companion #13634] keystore overhaul (iter) (#2345) Revert #2304 (#2349) Deprecate Currency: Companion for #12951 (#2334) Bump ci-linux image for rust 1.68 Always pass port to jsonrpsee WebSocket client (#2339) bump zombienet to v1.3.40 (#2348) Improve build times by disabling wasm-builder in `no_std` (#2308) Bump toml from 0.7.2 to 0.7.3 (#2340) Bump serde from 1.0.152 to 1.0.156 (#2329) Parachains should charge for proof size weight (#2326) dmp-queue: Store messages if already processed more than the maximum (#2343) [Companion #13615] Keystore overhaul (#2336) Bump quote from 1.0.23 to 1.0.26 (#2331)
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1 |
This PR adds the new nfts pallet to statemine config