Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Increase recovery delay for pov-recovery #2143

Closed
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions client/service/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,12 @@ where
let pov_recovery = PoVRecovery::new(
overseer_handle.clone(),
// We want that collators wait at maximum the relay chain slot duration before starting
// to recover blocks.
RecoveryDelay { min: core::time::Duration::ZERO, max: relay_chain_slot_duration },
// to recover blocks. Additionally, we wait at least half the slot time to give the
// relay chain the chance to increase availability.
RecoveryDelay {
min: relay_chain_slot_duration / 2,
max: relay_chain_slot_duration,
},
client.clone(),
import_queue,
relay_chain_interface.clone(),
Expand Down
5 changes: 1 addition & 4 deletions test/service/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -385,10 +385,7 @@ where
para_id,
relay_chain_interface,
import_queue: import_queue_service,
// The slot duration is currently used internally only to configure
// the recovery delay of pov-recovery. We don't want to wait for too
// long on the full node to recover, so we reduce this time here.
relay_chain_slot_duration: Duration::from_millis(6),
relay_chain_slot_duration: Duration::from_secs(6),
michalkucharczyk marked this conversation as resolved.
Show resolved Hide resolved
};

start_full_node(params)?;
Expand Down