-
Notifications
You must be signed in to change notification settings - Fork 378
Conversation
Bumps [clap](https://github.com/clap-rs/clap) from 3.1.18 to 3.2.2. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@v3.1.18...v3.2.2) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
This update was a bit of a mess and added a lot of warnings with unclear migration path. Some guidance on how to fix was given in this issue: clap-rs/clap#3822 |
@@ -47,7 +47,7 @@ sp-timestamp = { git = "https://github.com/paritytech/substrate", branch = "mast | |||
sp-trie = { git = "https://github.com/paritytech/substrate", branch = "master" } | |||
substrate-test-client = { git = "https://github.com/paritytech/substrate", branch = "master" } | |||
sc-cli = { git = "https://github.com/paritytech/substrate", branch = "master" } | |||
clap = { version = "3.2", features = ["derive"] } | |||
clap = { version = "3.2.5", features = ["derive", "deprecated"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need deprecated
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added the "deprecated" feature to clap so no cli options will be added in the old style anymore.
Now I read this.
But what does that mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So clap authors deprecated some of their derive API to streamline their API for the upcoming 4.0 release. However, the deprecation messaged did not make it obvious how to migrate. So after user feedback in clap-rs/clap#3822, they hid the deprecation messages behind feature flag "deprecated".
However, since I have already adopted the new API now, we want the deprecation messages for the old style so no one will go back.
bot merge |
Waiting for commit status. |
Bumps clap from 3.1.18 to 3.2.2.
Release notes
Sourced from clap's releases.
... (truncated)
Changelog
Sourced from clap's changelog.
... (truncated)
Commits
7836bed
chore: Releaseea09f67
docs: Go into more details on derive deprecationa770000
docs: Update changelog4001db6
Merge pull request #3827 from epage/unstable1ba6ef9
Merge pull request #3818 from mbhall88/patch-10a529c1
fix(derive): Switch default actions/parsers for unstable-v40c36710
docs(derive): Update deprecation notice52403cd
Update README.mdcc76d28
test(derive): Allow specializing tests for unstable-v43686244
test(derive): No longer supporting some wrapped typesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)