Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Telemetry should be splitted #154

Closed
bkchr opened this issue Jul 23, 2020 · 4 comments · Fixed by #301
Closed

Telemetry should be splitted #154

bkchr opened this issue Jul 23, 2020 · 4 comments · Fixed by #301
Assignees

Comments

@bkchr
Copy link
Member

bkchr commented Jul 23, 2020

Currently when submitting telemetry messages, we will be sending relay chain and parachain messages always to the same endpoint. This will not work, because the telemetry can not distinguish them.

As for logging, we need some sort of scopes to distinguish them. This can be done with slogger and the feature for setting a scope per future.

After we have scopes, we need to make the telemetry aware of these scopes and send the messages to the correct endpoint.

@cecton
Copy link
Contributor

cecton commented Aug 6, 2020

Are you sure it is sloggers? I don't see that feature... https://docs.rs/sloggers/1.0.1/sloggers/

@dvdplm
Copy link

dvdplm commented Oct 15, 2020

Can you elaborate on how the telemetry splitting will look on the cli side (multiple --telemetry-url?) and on from the point of view of telemetry (two separate streams? or single stream but "tagged" with the parachain message type?).

@cecton
Copy link
Contributor

cecton commented Oct 15, 2020

Can you elaborate on how the telemetry splitting will look on the cli side (multiple --telemetry-url?) and on from the point of view of telemetry (two separate streams? or single stream but "tagged" with the parachain message type?).

The parachain and relaychain arguments are already separated in the CLI: cumulus [parachain_args] -- [relaychain_args] so they can have different telemetry: cumulus --telemetry-url x -- --telemetry-url y

on from the point of view of telemetry (two separate streams? or single stream but "tagged" with the parachain message type?).

I'm not sure about that. I need to investigate. But as Basti said:

we replace the singleton with an instance that is passed everywhere

@bkchr
Copy link
Member Author

bkchr commented Oct 15, 2020

We will spawn two instances of the telemetry. Both will connect separately to the telemetry endpoint. We can optimize this later relative easy and only have one connected. But for now, we first need to get it working with instances.

@cecton cecton self-assigned this Jan 20, 2021
Maharacha pushed a commit to Maharacha/cumulus that referenced this issue May 10, 2023
* bump deprecated actions

* bump cancel workflow action even more
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants