Add argument & command validation in scope of repo #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzadp
reviewed
Aug 23, 2023
src/commander/commander.ts
Outdated
| @@ -38,6 +39,38 @@ export function getCommanderFromConfiguration( | |||
| let parsedCommand: ParseResults["parsedCommand"] = undefined; | |||
| const helpStr = `Refer to [help docs](${docsPath}) and/or [source code](${config.pipelineScripts.repository}).`; | |||
|
|
|||
| const exitOverride = (commandKey: string) => (e: CommanderError) => { | |||
| if (e.code === "commander.excessArguments") { | |||
| throw new Error(((e as CommanderError).message = `Unknown subcommand of "${commandKey}". ${helpStr}`)); | |||
There was a problem hiding this comment.
I'm not understanding the intentions here. Are we changing one error's message and throwing another new error?
Would it make sense to do instead:
throw new Error(`Unknown subcommand of "${commandKey}". ${helpStr}`);
or
(e as CommanderError).message = `Unknown subcommand of "${commandKey}". ${helpStr}`;
throw e;
There was a problem hiding this comment.
Yeah, by the looks of it
throw new Error(((e as CommanderError).message = `Unknown subcommand of "${commandKey}". ${helpStr}`));is equivalent to
throw new Error(`Unknown subcommand of "${commandKey}". ${helpStr}`);There was a problem hiding this comment.
haha i just copied from the bottom one, and refactored in really ugly way not even thinking 😂😂
thanks, fixed!
rzadp
approved these changes
Aug 23, 2023
| Cancel cases | ||
| */ | ||
| Cancel cases | ||
| */ |
There was a problem hiding this comment.
Automatic formatting with IDEA? :)
src/commander/commander.ts
Outdated
| @@ -38,6 +39,38 @@ export function getCommanderFromConfiguration( | |||
| let parsedCommand: ParseResults["parsedCommand"] = undefined; | |||
| const helpStr = `Refer to [help docs](${docsPath}) and/or [source code](${config.pipelineScripts.repository}).`; | |||
|
|
|||
| const exitOverride = (commandKey: string) => (e: CommanderError) => { | |||
| if (e.code === "commander.excessArguments") { | |||
| throw new Error(((e as CommanderError).message = `Unknown subcommand of "${commandKey}". ${helpStr}`)); | |||
There was a problem hiding this comment.
Yeah, by the looks of it
throw new Error(((e as CommanderError).message = `Unknown subcommand of "${commandKey}". ${helpStr}`));is equivalent to
throw new Error(`Unknown subcommand of "${commandKey}". ${helpStr}`);
Co-authored-by: Yuri Volkov <[email protected]> Signed-off-by: Maksym H <[email protected]>
…and-bot into mak-fix-commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #233
Tested locally
Also added validation of commands & subcommands in scope of repo - will fail with related message