Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the override compatible with latest format for the chainspec #154

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented Jan 31, 2024

That was introduced in
paritytech/polkadot-sdk#1256.

Without this fix updating the chain_spec pod in versi fails with:

+ BOOTNODES='"bootNodes": ["/dns/versi-tick-501-alice-node-0/tcp/30334/p2p/12D3KooWBsK6fux5wY2QqmNhE5HwfRVZiWFTL1T51XeBuE8op49t","/dns/versi-tick-501-bob-node-0/tcp/30334/p2p/12D3KooWMD4MDy2Vks4ErjTDaN6xb1P1Q5i5XTv5S3p1sj81tKzd"],'+ sed 's;"bootNodes.*;"bootNodes": ["/dns/versi-tick-501-alice-node-0/tcp/30334/p2p/12D3KooWBsK6fux5wY2QqmNhE5HwfRVZiWFTL1T51XeBuE8op49t","/dns/versi-tick-501-bob-node-0/tcp/30334/p2p/12D3KooWMD4MDy2Vks4ErjTDaN6xb1P1Q5i5XTv5S3p1sj81tKzd"],;' -i /dir/tick-dev-plain-01.json+ 


/usr/local/bin/polkadot-parachain build-spec --chain /dir/tick-dev-plain-01.json --rawError: Service(Other("Error parsing spec file: expected value at line 40 column 5"))

That was introduced in
paritytech/polkadot-sdk#1256.

Without this fix updating the chain_spec pod in versi fails with:
```
+ BOOTNODES='"bootNodes": ["/dns/versi-tick-501-alice-node-0/tcp/30334/p2p/12D3KooWBsK6fux5wY2QqmNhE5HwfRVZiWFTL1T51XeBuE8op49t","/dns/versi-tick-501-bob-node-0/tcp/30334/p2p/12D3KooWMD4MDy2Vks4ErjTDaN6xb1P1Q5i5XTv5S3p1sj81tKzd"],'+ sed 's;"bootNodes.*;"bootNodes": ["/dns/versi-tick-501-alice-node-0/tcp/30334/p2p/12D3KooWBsK6fux5wY2QqmNhE5HwfRVZiWFTL1T51XeBuE8op49t","/dns/versi-tick-501-bob-node-0/tcp/30334/p2p/12D3KooWMD4MDy2Vks4ErjTDaN6xb1P1Q5i5XTv5S3p1sj81tKzd"],;' -i /dir/tick-dev-plain-01.json+ /usr/local/bin/polkadot-parachain build-spec --chain /dir/tick-dev-plain-01.json --rawError: Service(Other("Error parsing spec file: expected value at line 40 column 5"))
```

Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh alexggh merged commit d98808e into main Jan 31, 2024
2 checks passed
@alexggh alexggh deleted the alexaggh/fix_tick_specs branch January 31, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants