This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Update to latest susbtrate and contracts pallet #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
commented
Feb 23, 2021
athei
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot really comment on this client scaffold but the runtime looks good to me.
Client scaffold is just boilerplate copied from |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contracts
3.0
is here: paritytech/substrate#8175.This PR updates to substrate master (currently paritytech/substrate@e6ac7e7). For now we will continue to use github dependencies for
substrate
in aniticipation of migration to a parachain #30, which requires dependencies oncumulus
andpolkadot
.Address
is now asp_runtime::MultiAddress<AccountId, ()>
, as per the node template (see More Extensible Multiaddress Format substrate#7380), so clients need to be updated accordingly.parameter_types!
are copied verbatim from the substratenode-runtime
https://github.com/paritytech/substrate/blob/36b8a962b254dc4d834477469a68c83c3060dd6b/bin/node/runtime/src/lib.rs#L716-L739