This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Update setup for monitoring on the dedicated machine #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-paulo-parity
force-pushed
the
fix
branch
from
September 2, 2021 03:29
0026b2d
to
307fa36
Compare
joao-paulo-parity
force-pushed
the
fix
branch
from
September 2, 2021 03:44
f0b0c0b
to
ab120c0
Compare
joao-paulo-parity
force-pushed
the
fix
branch
from
September 2, 2021 03:50
ab120c0
to
e82168a
Compare
update install_ref
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR's main goal is to refactor bench-bot's setup so that it'll be possible to have the logs + monitoring without overhead.
After paritytech/substrate#9507 (comment) was reported, I tried to look into the logs to but the bot is currently running in @shawntabrizi's session which has limited buffer history size (I think it's 2000 lines). We once had the bot running in a service with full access to the logs but apparently that introduced some overhead (#47 (comment)).
The performance degradation from the previous approach seems to be coming from running the bot as a service. After this pull request we'll instead run the bot as a normal process and, in parallel, also have a monitoring service dedicated for feeding the bot's output to the systemd journal, that way it'll be available on Grafana's logs.