improved logs

paritytech-stg · Oct 30, 2023 · 7129931 · 7129931
1 parent c32feda
commit 7129931
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/github/pullRequest.ts b/src/github/pullRequest.ts
@@ -115,9 +115,11 @@ export class PullRequestApi {
     if (users || teams) {
       const validArray = (array: string[] | undefined): boolean => !!array && array.length > 0;
       const reviewersLog = [
-        validArray(users) ? `Teams: ${JSON.stringify(users)}` : "",
-        validArray(teams) ? `Users: ${JSON.stringify(teams)}` : "",
-      ].join(" - ");
+        validArray(users) ? `Teams: ${JSON.stringify(users)}` : undefined,
+        validArray(teams) ? `Users: ${JSON.stringify(teams)}` : undefined,
+      ]
+        .filter((e) => !!e)
+        .join(" - ");
 
       this.logger.info(`Requesting reviews from ${reviewersLog}`);
 

diff --git a/src/runner.ts b/src/runner.ts
@@ -41,7 +41,7 @@ export class ActionRunner {
     private readonly polkadotApi: TeamApi,
     private readonly checks: GitHubChecksApi,
     private readonly logger: ActionLogger,
-  ) {}
+  ) { }
 
   /**
    * Fetches the configuration file, parses it and validates it.
@@ -191,6 +191,8 @@ export class ActionRunner {
       finalReport.usersToRequest = concatArraysUniquely(finalReport.usersToRequest, report.usersToRequest);
     }
 
+    this.logger.debug(`Request data: ${JSON.stringify(finalReport)}`);
+
     let { teamsToRequest, usersToRequest } = finalReport;
 
     /**