Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple country selection in table columns #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pixelastronauts
Copy link

This PR extends the functionality of the CountryColumn to support multiple country selection. While the input component already supported this feature, the table column did not. The changes include:

  • Updated CountryColumn class to handle array inputs
  • Added method to convert multiple country codes to comma-separated names
  • Included new test case to verify multiple selection functionality
  • Some styling fixes on the view

@AlexisSerneels
Copy link
Contributor

Thank you @pixelastronauts for this.
Would you mind correcting the failing tests and I'll merge.

@pixelastronauts
Copy link
Author

Hey @AlexisSerneels I removed the test for now, as the testing of a custom column is not that straightforward in Filament as I expected. If you think you've got a quick way to test it, let me know so I can implement the test later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants