fix: Changing all middlewares to use asynchronous policy execution. (fixes #232) #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pardahlman
reviewed
Jun 12, 2017
There was a problem hiding this comment.
@videege thank you for this. I tend to avoid GetAwaiter().GetResult(), see comments.
| @@ -31,7 +31,7 @@ public BasicPublishMiddleware(IExclusiveLock exclusive, BasicPublishOptions opti | |||
| [RetryKey.PublishMandatory] = mandatory, | |||
| [RetryKey.BasicProperties] = basicProps, | |||
| [RetryKey.PublishBody] = body, | |||
| }); | |||
| }).GetAwaiter().GetResult(); | |||
There was a problem hiding this comment.
Since we're planning to go all in, I think we should make the call to this method async. That way, we get rid of the .GetAwaiter().GetResult(). Makes sense?
| { | ||
| policyName = policyName ?? PolicyKeys.DefaultPolicy; | ||
| context.Properties.TryAdd(policyName, poliocy); | ||
| context.Properties.TryAdd(policyName, policy); |
| contextData: new Dictionary<string, object> | ||
| { | ||
| [RetryKey.PipeContext] = context | ||
| }); | ||
| }).GetAwaiter().GetResult(); |
There was a problem hiding this comment.
I think this method should be async
|
I agree with your comments - I'll take a look at updating the PR tonight. |
…unctions to avoid the use of GetAwaiter().
|
I pushed a change making everything async - what do you think? |
|
Looks good! Thanks! |
|
Any chance you could push a package release including this fix? ping @pardahlman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the Polly enricher to use asynchronous policy execution. (fixes #232)
Note: I wasn't sure the best way to do this, but you might want to add some kind of detection in to reject the registration of synchronous policies, or add it to the docs.
Check List
stablebranch.