Prevent channel shutdown if still active #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 23, 2016 00:38
These operations are async, so it is nicer to don't expect key to be in ditionary but rather perform TryGet:s, and log hard.
This is done by checking number of publishes made during one second. If none, then the channel is considered inactive and closed. If there are any publishes, it will check again after ten seconds.
So that it may be overriden. This is because the strategy with the two timers might not suit everyone.
pardahlman
pushed a commit
that referenced
this pull request
Jan 23, 2016
Prevent channel shutdown if still active
|
This issue will be part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the code in
Publisherso that where it previously closed the channel after 10 seconds no matter what, it will now see if there are still publishing going on on the channel and if that's the case wait for another 10 seconds before checking again.While looking at the publishing flow, I had a look at the
PublishAcknowledgerand made sure that the entities in the dictionary existed before accessing them.