Update MessageSequence Extension #74
Assignees
Milestone
Comments
pardahlman
pushed a commit
that referenced
this issue
Mar 30, 2016
pardahlman
pushed a commit
that referenced
this issue
Mar 30, 2016
This is because when a message sequence is completed, we want to get the config for a message type and we only have the type. Instead of constructing a generic argument, I find it cleaner to add methods that takes a Type argument, too.
pardahlman
pushed a commit
that referenced
this issue
Mar 30, 2016
This decreases the work load on the client by having the broker route messages for global messages id that the client is interested in.
pardahlman
pushed a commit
that referenced
this issue
Apr 4, 2016
Instead of concatinating finished+skipped.
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One weakness in how the
MessageSequenceextension is working is that it listens to messages with the same routing key as any other subscriber for that message. This means that if the message it is listening for is published a lot, it will receive it multiple times while still only being interested in a couple of those. When #73 is done, we should make sure that the extension binds for a specific message id ([routingkey].[globalmessageid). This way, only messages for the specific message sequence is routed to the queue. Once a message sequence is finished, it should remove the bindings for that sequence. As a consequence, to this we will have a slight performance hit in creating a sequence as it will have to make more roundtrips to the brokerThe text was updated successfully, but these errors were encountered: