Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve extraction of Application Name #61

Closed
pardahlman opened this issue Feb 23, 2016 · 1 comment
Closed

Improve extraction of Application Name #61

pardahlman opened this issue Feb 23, 2016 · 1 comment
Labels
feature
Milestone
1.8.11

Comments

@pardahlman
Copy link
Owner

There's a private method in NamingConvention called GetApplicationName. The algorithm today isn't to refined. Scenarios that should be handled:

  • "C:\\Projects\\Temp\\My.Console.App\\bin\\Debug\\RawException.vshost.exe" (console app)
  • "C:\\Projects\\Temp\\My.Application\\My.Application.Web\\bin" (hosted in IIS)
  • "C:\\Application\\PRODUCTION\\My.Windows.Service\\2.2.1.916\\" (windows service, deployed with version number)

We expect the Application Name to be MyConsoleApp, MyApplicationWeb and MyWindowsService.

This method could be public and unit tested.
@pardahlman pardahlman added this to the 1.8.11 milestone Feb 23, 2016
Originalutter pushed a commit to Originalutter/RawRabbit that referenced this issue Feb 23, 2016
(pardahlman#61) Extends support for GetApplicationName()
95ee620
Originalutter pushed a commit to Originalutter/RawRabbit that referenced this issue Feb 23, 2016
(pardahlman#61) Extends support for GetApplicationName()
cb9fb8f
Originalutter pushed a commit to Originalutter/RawRabbit that referenced this issue Feb 23, 2016
(pardahlman#61) Extends support for GetApplicationName()
a3a1443
Originalutter pushed a commit to Originalutter/RawRabbit that referenced this issue Feb 23, 2016
(pardahlman#61): Removes string.Empty check for application name
d74ecf8
Originalutter pushed a commit to Originalutter/RawRabbit that referenced this issue Feb 25, 2016
(pardahlman#61) Extends support for GetApplicationName()
e9a1693
Originalutter pushed a commit to Originalutter/RawRabbit that referenced this issue Feb 25, 2016
(pardahlman#61) Removes string.Empty check for application name
c7eef30
Originalutter pushed a commit to Originalutter/RawRabbit that referenced this issue Feb 25, 2016
(pardahlman#61) Updates ApplicationName extraction
a166e40
Originalutter pushed a commit to Originalutter/RawRabbit that referenced this issue Mar 1, 2016
(pardahlman#61) Updates ApplicationName extraction
9b9663d
Originalutter pushed a commit to Originalutter/RawRabbit that referenced this issue Mar 1, 2016
(pardahlman#61) Updates ApplicationName extraction
99465cf
pardahlman pushed a commit that referenced this issue Mar 1, 2016
(#61) Minor cleanup
bf71cb5 
Fixing some small things:

* Remove unused field
* Assign value of _applicationName in ctor
* Made iis application name to a field
pardahlman pushed a commit that referenced this issue Mar 1, 2016
(#61) Guard against too long queue names
9781194
@pardahlman
Copy link
Owner Author

Thanks @Originalutter -- I've made some changes in 9781194. We'll discuss it later if you want to. Will be part of 1.8.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
1.8.11
Development

No branches or pull requests
1 participant
@pardahlman