-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected PublishConfirmExceptions with 2.x #270
Comments
Thanks for reporting this. I must admit that I haven't tried this myself, but it is something that definitely should work. It is very possible that the publish sequence resets after the connection goes down and recovers. There is always the option to disable publish confirms alltogether by calling you outing operations (publish etc) with |
Yes, after the broker restarts I see a single entry in I'd like to keep publish confirmations if at all possible :) |
I've looked into this and adjusted the internal counter for the publish sequence to reset if the sequence has for some reason been reset. This solution seems to be robust for multiple concurrent publishers using the same channel. |
This seems to work, unless any of the publish tasks were cancelled while the broker was down. For example, if the publish call looks something like this (if the publish doesn't succeed in 5s, cancel the task):
When the broker comes back up, every subsequent publish results in an immediate |
Are you sure? I get an try
{
await _client.PublishAsync(new ValueCreationFailed(), token: timeoutCts.Token);
}
catch (OperationCanceledException) { } |
Gah, my mistake, I was working with the wrong source - your commit has fixed the issue in all cases! |
Hi. I have faced the same issue in rc5. With moderate load of ~400 events. Singular publishes work fine. Increasing wait time for publish confirm to 1 minute is not helping. Events are all delivered though. Temporarily disabled publish ack with
P.s. @pardahlman thanks for awesome framework |
I'm seeing some odd behaviour when the broker goes down when using using pub/sub.
After the broker comes back up, every single publish results in an immediate
PublishConfirmException
with messageThe broker did not send a publish acknowledgement for message # within 0:00:10
.Messages are still being delivered though.
The text was updated successfully, but these errors were encountered: