Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide error when diagnostic is malformed #9283

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Oct 1, 2023

Still print diagnostics when the end column is before the start column (and just silently ignore the end in that case). Previously this caused a RangeError: Invalid count value without ever printing the original error.

"Fixes" #9112 (now the actual error should be printed, but the underlying diagnostic is of course still malformed)

@mischnic mischnic requested a review from devongovett October 1, 2023 10:13
@mischnic mischnic force-pushed the graceful-codeframe-columns branch from f7bdca6 to f45853e Compare October 1, 2023 10:13
@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.43s -0.00ms
Cached 245.00ms +4.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/index.ff03421b.js 1.48kb +0.00b 358.00ms +22.00ms ⚠️
dist/legacy/index.e9bb1616.js 1.06kb +0.00b 359.00ms +23.00ms ⚠️
dist/modern/index.4a29d309.js 921.00b +0.00b 358.00ms +22.00ms ⚠️
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 266.00ms +15.00ms ⚠️
dist/modern/index.31cedca9.css 94.00b +0.00b 265.00ms +15.00ms ⚠️

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 3.75s -84.00ms
Cached 392.00ms +1.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.e9dc4a75.js 3.92kb +0.00b 316.00ms +27.00ms ⚠️
dist/UserProfile.8945a243.js 1.38kb +0.00b 316.00ms +27.00ms ⚠️
dist/NotFound.8b44a81d.js 269.00b +0.00b 316.00ms +27.00ms ⚠️
dist/logo.8dd07848.png 244.00b +0.00b 226.00ms +12.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.e9dc4a75.js 3.92kb +0.00b 358.00ms +48.00ms ⚠️
dist/UserProfile.8945a243.js 1.38kb +0.00b 358.00ms +48.00ms ⚠️
dist/NotFound.8b44a81d.js 269.00b +0.00b 359.00ms +49.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 30.55s -391.00ms
Cached 2.05s +23.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/media-viewer.38e3999a.js 536.13kb +0.00b 9.57s +2.35s ⚠️
dist/ConfigPanelFieldsLoader.182d39bc.js 303.43kb +0.00b 6.75s -471.00ms 🚀
dist/card.d06de810.js 138.91kb +0.00b 6.75s -457.00ms 🚀
dist/ElementBrowser.e8f01080.js 61.94kb +0.00b 6.75s -457.00ms 🚀
dist/esm.bfca2115.js 59.30kb +0.00b 6.75s -455.00ms 🚀
dist/ConfigPanelFieldsLoader.2b7c03be.js 15.74kb +0.00b 6.75s -457.00ms 🚀
dist/ui.8c117104.js 14.48kb +0.00b 6.75s -457.00ms 🚀
dist/ConfigPanelFieldsLoader.5dfde67d.js 13.63kb +0.00b 6.75s -457.00ms 🚀
dist/pdfRenderer.01deafa1.js 12.04kb +0.00b 6.75s -468.00ms 🚀
dist/mobile-upload.3baad8e4.js 7.79kb +0.00b 6.75s -468.00ms 🚀
dist/mobile-upload.7a892a37.js 7.79kb +0.00b 6.75s -466.00ms 🚀
dist/ru.0cf3f40e.js 2.81kb +0.00b 6.75s -457.00ms 🚀
dist/uk.282f23b1.js 2.76kb +0.00b 6.75s -456.00ms 🚀
dist/codeViewerRenderer.51140ec8.js 2.61kb +0.00b 9.56s +2.34s ⚠️
dist/th.137e1013.js 2.60kb +0.00b 6.75s -457.00ms 🚀
dist/vi.b46097db.js 2.09kb +0.00b 6.75s -456.00ms 🚀
dist/tr.c85d90a9.js 2.03kb +0.00b 6.75s -456.00ms 🚀
dist/sv.1c06c95c.js 1.98kb +0.00b 6.75s -457.00ms 🚀
dist/zh_TW.b7c55aa6.js 1.86kb +0.00b 6.75s -456.00ms 🚀
dist/zh.b01fe721.js 1.84kb +0.00b 6.75s -456.00ms 🚀
dist/workerHasher.540c9790.js 1.56kb +0.00b 6.75s -467.00ms 🚀
dist/workerHasher.c840c607.js 1.56kb +0.00b 6.75s -466.00ms 🚀
dist/sk.4be9c93f.js 656.00b +0.00b 6.75s -457.00ms 🚀
dist/simpleHasher.c14e20b4.js 589.00b +0.00b 6.75s -468.00ms 🚀
dist/simpleHasher.23db7a52.js 589.00b +0.00b 6.75s -466.00ms 🚀
dist/index.html 248.00b +0.00b 6.69s +1.67s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/pdfRenderer.ba28cccc.js 1.11mb +0.00b 11.18s +667.00ms ⚠️
dist/media-viewer.38e3999a.js 536.13kb +0.00b 9.38s +2.62s ⚠️
dist/pdfRenderer.01deafa1.js 12.04kb +0.00b 9.38s +2.62s ⚠️
dist/pt_BR.b9e37d37.js 2.06kb +0.00b 6.31s +1.46s ⚠️
dist/pt_PT.e211e609.js 635.00b +0.00b 6.31s +1.46s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 2.77s +38.00ms
Cached 330.00ms +24.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants