-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validator-eslint: support eslint ^7.0.0 in devDeps and peerDeps #8997
validator-eslint: support eslint ^7.0.0 in devDeps and peerDeps #8997
Conversation
@mischnic @mattcompiles May the GitHub Action workflows for this PR be unlocked kind sers? 👼 |
Looks like you'll need some of the changes from #8580 to fix the lint errors |
c28d640
to
84422e7
Compare
84422e7
to
5d4e124
Compare
You also need to add the flowconfig change from #8580 |
eb0a9e6
to
4a5f105
Compare
Breaking Benchmarks action addressed in parcel-bundler/parcel-benchmark-action#93 and parcel-bundler/parcel-benchmark-action#94 |
Integration tests run fine on Node.js 16 on Windows: https://github.com/parcel-bundler/parcel/actions/runs/4934084435/jobs/8818729879?pr=8997
But fail on Node.js 14 on Windows: https://github.com/parcel-bundler/parcel/actions/runs/4934084435/jobs/8818729522?pr=8997
Perhaps it's about time to drop support for Node.js 14 anyway nowthat it's EoL..? |
↪️ Pull Request
validator-eslint
: supporteslint
^7.0.0
as well as existing^6.0.0
in devDeps and peerDeps^7.0.0
by default. This dedupes eslint in the lockfile.✔️ PR Todo